Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate modified_lines_in_file to context #730

Merged
merged 1 commit into from
Oct 3, 2020
Merged

Delegate modified_lines_in_file to context #730

merged 1 commit into from
Oct 3, 2020

Conversation

Quintasan
Copy link
Contributor

@sds This went under the radar since modified_files is delegated via Overcommit::Hook::Base.

Now that I tried writing a custom hook I noticed modified_lines_in_file is not available inside Overcommit::Hook::CommitMsg::Base. I decided to expose only the method I need but I think it's worth thinking about if we want to delegate all methods that come from included modules by default

This went under the radar since `modified_files` is delegated via
`Overcommit::Hook::Base`.
@Quintasan
Copy link
Contributor Author

@sds ding

@sds sds merged commit ed0d0ec into sds:master Oct 3, 2020
@sds
Copy link
Owner

sds commented Oct 3, 2020

Thanks for the ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants