Fix YamlLint hook.
#719
Merged
Fix YamlLint hook.
#719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when yamllint was failing, the exit code of the tool was reflecting that. However, recently yamllint introduced `--strict` parameter to do that. Without, it always returns success no matter if lints were successful or failed. Which caused false-positives in ovecommit, which was thinking that everything is okay. This fix adds `--strict` to `yamllint` invocation, to bring back proper behavior, and force hook to fail, when the tool fails.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when yamllint was failing, the exit code of the tool was
reflecting that. However, recently yamllint introduced
--strictparameter to do that. Without, it always returns success no matter if
lints were successful or failed. Which caused false-positives in
ovecommit, which was thinking that everything is okay.
This fix adds
--stricttoyamllintinvocation, to bring back properbehavior, and force hook to fail, when the tool fails.