Stylelint linter added in pre-hook #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sds
reviewed
Jul 30, 2018
README.md
Outdated
| @@ -546,6 +546,7 @@ issue](https://github.com/brigade/overcommit/issues/238) for more details. | |||
| * [SlimLint](lib/overcommit/hook/pre_commit/slim_lint.rb) | |||
| * [Sqlint](lib/overcommit/hook/pre_commit/sqlint.rb) | |||
| * [Standard](lib/overcommit/hook/pre_commit/standard.rb) | |||
| * [StyleLint](lib/overcommit/hook/pre_commit/style_lint.rb) | |||
There was a problem hiding this comment.
Nit: If the actual project name is capitalized "Stylelint", then we should use that same capitalization, and have the file be named stylelint.rb appropriately.
config/default.yml
Outdated
| enabled: true | ||
| description: 'Check styles with Stylelint' | ||
| require_executable: 'stylelint' | ||
| flags: ['-f compact'] |
There was a problem hiding this comment.
These need to be split into separate arguments ['-f', 'compact'], unless the stylelint CLI accepts -f compact as a single argument, but that would be surprising.
config/default.yml
Outdated
| @@ -711,6 +711,17 @@ PreCommit: | |||
| install_command: 'npm install -g standard' | |||
| include: '**/*.js' | |||
|
|
|||
| StyleLint: | |||
| enabled: true | |||
There was a problem hiding this comment.
We do not enable hooks by default unless they are truly applicable to almost any project. Set this to false.
|
@sds Thanks for your comments. I hope now will be ok 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in response with #514, which @brianbancroft started a PR but never had a chance to finish it.
The main problem with this linter was the kind of output that Stylelint was giving. Overcommit wasn't ready to handle multiline errors for the same file. So I asked if it could be possible to do a compact format for that stylelint#3415.
Thanks to @ntwb, that was possible (PR 3488). Therefore, I was able to implement the new linter at overcommit.
To run properly the linter in the CLI:
stylelint "**/*.css" -f compact. I would really appreciate if someone can verify I added correctly the way to run it indefault.ymlI would like to say that this PR is made based on @briancroft 's PR. He deserves part of the contribution. As well @ntwb to make it possible from the Style lint side
Feel free to code review and verify everything is ok 👍