Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Pep8 and Pep257 Hooks #493

Merged
merged 1 commit into from
Jun 4, 2017
Merged

Rename Pep8 and Pep257 Hooks #493

merged 1 commit into from
Jun 4, 2017

Conversation

proinsias
Copy link
Contributor

@proinsias proinsias commented May 31, 2017

The pep8 and pep257 projects have been renamed to pycodestyle
and pydocstyle, respectively.

To reflect these changes:

  • The references to the former projects in README.md and default.yml
    have been updated.

  • The ruby files under pre_commit for the former projects have been
    kept for backwards compatibility with existing .overcommit.yml
    files.

  • New ruby files have been created under pre-commit.

Copy link
Contributor

@trotzig trotzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @proinsias! Instead of just keeping the old files, would it make sense to have them call the new classes?

@proinsias
Copy link
Contributor Author

@trotzig – so that an existing .overcommit.yml with a Pep8 section would result in overcommit calling pycodestyle? I was assuming that the user might not have pycodestyle installed yet, but would likely still have pep8 installed.

@trotzig
Copy link
Contributor

trotzig commented Jun 2, 2017

I was thinking we could just inject the name of the binary to some shared code. But yeah, probably not worth the effort.

One thing we could do is to add a comment in the default config at the place for the old hooks to mention that they are deprecated.

@trotzig
Copy link
Contributor

trotzig commented Jun 2, 2017

The appveyor failure looks unrelated to your change. @sds, looks like it could be failing because of changes you made to LineEndings in afdebb. Do you have any ideas?

The `pep8` and `pep257` projects have been renamed to `pycodestyle`
and `pydocstyle`, respectively.

To reflect these changes:

* The references to the former projects in `README.md` and `default.yml`
  have been updated.

* The ruby files under `pre_commit` for the former projects have been
  kept for backwards compatibility with existing `.overcommit.yml`
  files.

* New ruby files have been created under `pre-commit`.
@proinsias
Copy link
Contributor Author

@trotzig – I've added comments to the default config as requested.

@trotzig
Copy link
Contributor

trotzig commented Jun 4, 2017

Thanks!

@trotzig trotzig merged commit 717b2f4 into sds:master Jun 4, 2017
@proinsias proinsias deleted the proinsias/pystyle branch June 5, 2017 02:13
@sds
Copy link
Owner

sds commented Jun 9, 2017

@trotzig I don't have access to a Windows machine to look into that failure, but given the test that's failing is for a pretty minor feature, I've changed it to not run on Windows environments for now (see d446314).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants