-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Pep8 and Pep257 Hooks #493
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @proinsias! Instead of just keeping the old files, would it make sense to have them call the new classes?
@trotzig – so that an existing |
I was thinking we could just inject the name of the binary to some shared code. But yeah, probably not worth the effort. One thing we could do is to add a comment in the default config at the place for the old hooks to mention that they are deprecated. |
The appveyor failure looks unrelated to your change. @sds, looks like it could be failing because of changes you made to |
The `pep8` and `pep257` projects have been renamed to `pycodestyle` and `pydocstyle`, respectively. To reflect these changes: * The references to the former projects in `README.md` and `default.yml` have been updated. * The ruby files under `pre_commit` for the former projects have been kept for backwards compatibility with existing `.overcommit.yml` files. * New ruby files have been created under `pre-commit`.
@trotzig – I've added comments to the default config as requested. |
Thanks! |
The
pep8
andpep257
projects have been renamed topycodestyle
and
pydocstyle
, respectively.To reflect these changes:
The references to the former projects in
README.md
anddefault.yml
have been updated.
The ruby files under
pre_commit
for the former projects have beenkept for backwards compatibility with existing
.overcommit.yml
files.
New ruby files have been created under
pre-commit
.