Add --no-summary flag to haml-lint
#484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haml-lint now prints a summary at the end of the run. E.g. 11 files inspected, 1 lint detected We need to disable that so that overcommit can parse the output correctly. Here's some more context: sds/haml-lint#176 This will help resolve some of the issues seen in #483.
|
Ping @michaelherold, thanks for providing that flag in haml-lint. :) |
sds
approved these changes
Apr 6, 2017
There was a problem hiding this comment.
Looks good to me. It's unfortunate flag changes like this will break HamlLint pre-commit hooks for those running older versions of haml-lint, but I suppose the silver lining is that this will force them to upgrade, which will allow them to benefit from the new features.
|
Ah, good point. I hadn't thought of that, but I don't see any other way than to just introduce it and force people to upgrade. I'm ignoring the appveyor tests for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haml-lint now prints a summary at the end of the run. E.g.
11 files inspected, 1 lint detected
We need to disable that so that overcommit can parse the output
correctly.
Here's some more context: sds/haml-lint#176
This will help resolve some of the issues seen in #483.