Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some protips #340

Merged
merged 2 commits into from
Feb 12, 2016
Merged

Add some protips #340

merged 2 commits into from
Feb 12, 2016

Conversation

lencioni
Copy link
Collaborator

No description provided.

jawshooah
jawshooah reviewed Feb 11, 2016
View reviewed changes
lib/overcommit/hook/pre_commit/execute_permissions.rb
@@ -2,6 +2,16 @@ module Overcommit::Hook::PreCommit
# Checks for files with execute permissions, which are usually not necessary
# in source code files (and are typically caused by a misconfigured editor
# assigning incorrect default permissions).
#
# Protip: if you have some files that you want to allow execute permissions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this just basic functionality available to every hook? Does it warrant a protip?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is. But, since people are filing issues asking this question, I think that is evidence enough that it could save people time to have a note here. It helps them apply the feature for this case, which I think is a win.

@lencioni
Add protip about npm run lint to EsLint pre-commit hook
ab1d8c9 
This might not be obvious to some folks (see #338), but could be
helpful, so I am adding a note.
@lencioni
Add protip about disabling ExecutePermissions
d4b946f 
Some people have been confused about how to use this hook when they have
files that should have execute permissions (#339). I am hoping that this
comment will help out future people.
@sds
Copy link
Owner

sds commented Feb 12, 2016

👍

lencioni added a commit that referenced this pull request Feb 12, 2016
@lencioni
Merge pull request #340 from brigade/protips
3206ea4 
Add some protips
@lencioni lencioni merged commit 3206ea4 into master Feb 12, 2016
@lencioni lencioni deleted the protips branch February 12, 2016 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lencioni @sds @jawshooah