fix(patmat): Use childPrefix to resolve path-dependent sealed children #23771
+32
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nox213
commented
Aug 17, 2025
| val parentPre = parent.normalizedPrefix | ||
| val defaultRef = if (child.isTerm) child.termRef else child.typeRef | ||
|
|
||
| if (parentSym.isClass && parentPre.isInstanceOf[TermRef]) { |
There was a problem hiding this comment.
guard for match types and cases without prefix
|
I will look into CI failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #23369
This PR fixes an issue where path-dependent types were not resolved correctly when calculating the space of a scrutinee's children for exhaustiveness checking. The type checking was performed from the perspective of the child's definition-site (Module), which failed to account for type members refined at the use-site.