Skip to content

derive Hash (and not Copy) for ranges #34180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 15, 2016
Merged

derive Hash (and not Copy) for ranges #34180

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85e76e8
derive Hash for ranges
durka Jun 9, 2016
9e78cd7
make RangeInclusive Hash and !Copy
durka Jun 9, 2016
53618c3
test traits defined on ranges
durka Jun 9, 2016
df924ca
add fixme about duplicated errors
durka Jun 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make RangeInclusive Hash and !Copy 
[breaking-change] due to the removal of Copy which shouldn't have been there in the first place, as per policy set forth in #27186.
  • Loading branch information
@durka
durka committed Jun 9, 2016
commit 9e78cd73b5c4254efda9fe57be56b8b374383812
2 changes: 1 addition & 1 deletion src/libcore/ops.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1669,7 +1669,7 @@ impl<Idx: PartialOrd<Idx>> RangeTo<Idx> {
/// assert_eq!(arr[1...2], [ 1,2 ]); // RangeInclusive
/// }
/// ```
#[derive(Copy, Clone, PartialEq, Eq)]
#[derive(Clone, PartialEq, Eq, Hash)] // not Copy -- see #27186
#[unstable(feature = "inclusive_range", reason = "recently added, follows RFC", issue = "28237")]
pub enum RangeInclusive<Idx> {
/// Empty range (iteration has finished)
Expand Down