Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two incorrect turbofish suggestions #139264

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

freyacodes
Copy link
Contributor

This fixes #121901

This is my contribution to Rust, and my first contribution to a language parser that I didn't write myself.
I am a bit outside my depth here, so any constructive criticism is appreciated.

@rustbot
Copy link
Collaborator

rustbot commented Apr 2, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 2, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Apr 2, 2025

r? parser (bandwidth)

@rustbot rustbot assigned petrochenkov and unassigned jieyouxu Apr 2, 2025
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 2, 2025

📌 Commit d8d27ca has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 2, 2025
…, r=petrochenkov

Fix two incorrect turbofish suggestions

This fixes rust-lang#121901

This is my contribution to Rust, and my first contribution to a language parser that I didn't write myself.
I am a bit outside my depth here, so any constructive criticism is appreciated.
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2025
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#138992 (literal pattern lowering: use the pattern's type instead of the literal's in `const_to_pat`)
 - rust-lang#139211 (interpret: add a version of run_for_validation for &self)
 - rust-lang#139235 (`AstValidator` tweaks)
 - rust-lang#139237 (Add a dep kind for use of the anon node with zero dependencies)
 - rust-lang#139260 (Add dianqk to codegen reviewers)
 - rust-lang#139264 (Fix two incorrect turbofish suggestions)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 278bc67 into rust-lang:master Apr 2, 2025
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2025
Rollup merge of rust-lang#139264 - freyacodes:fix/bad-turbofish-hints, r=petrochenkov

Fix two incorrect turbofish suggestions

This fixes rust-lang#121901

This is my contribution to Rust, and my first contribution to a language parser that I didn't write myself.
I am a bit outside my depth here, so any constructive criticism is appreciated.
@rustbot rustbot added this to the 1.88.0 milestone Apr 2, 2025
@freyacodes freyacodes deleted the fix/bad-turbofish-hints branch April 3, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect suggestion to add turbofish when > is missing
5 participants