Start using with_native_path in std::sys::fs
#138832
Open
+178
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
O-unix
This comment has been minimized.
This comment has been minimized.
ChrisDenton
force-pushed
the
with_native_path
branch
2 times, most recently
from
98ace21 to
b7e9898
Compare
This comment has been minimized.
This comment has been minimized.
ChrisDenton
force-pushed
the
with_native_path
branch
from
b7e9898 to
582d6ee
Compare
This comment has been minimized.
This comment has been minimized.
ChrisDenton
force-pushed
the
with_native_path
branch
from
582d6ee to
265ee9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, each platform should use their own native path type internally. This will, for example, allow passing a
CStrdirectly tostd::fs::File::openand therefore avoid the need for allocating a new null-terminated C string.However, doing that for every function and platform all at once makes for a large PR that is way too prone to breaking. So this PR does some minimal refactoring which should help progress towards that goal. The changes are Unix-only and even then I avoided functions that require more changes so that this PR is just moving things around.
r? joboet