Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable Fuchsia test job to unblock queue #138690

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Mar 19, 2025

See https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/fuchsia.20failure/with/506637259 for efforts to fix the test job.

This PR temporarily disables the Fuchsia test job to unblock the queue, so that neither the Fuchsia maintainers nor T-infra maintainers should feel pressured to fix the job ASAP.

Please feel free to re-enable once the test job is fixed.
FYI @erickt since you or other Fuchsia maintainers will need to revert this change to merge Fuchsia test job fixes in the future.

r? infra-ci

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 19, 2025
Copy link
Member

@jhpratt jhpratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm "only" a libs reviewer and as such can't (more like shouldn't) give this formal approval, but this is about as straightforward as it gets for CI.

@Kobzol
Copy link
Contributor

Kobzol commented Mar 19, 2025

@bors r+ p=101

@bors
Copy link
Contributor

bors commented Mar 19, 2025

📌 Commit 351e0f7 has been approved by Kobzol

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 19, 2025

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2025
@bors
Copy link
Contributor

bors commented Mar 19, 2025

⌛ Testing commit 351e0f7 with merge 1370611...

@bors
Copy link
Contributor

bors commented Mar 19, 2025

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 1370611 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 19, 2025
@bors bors merged commit 1370611 into rust-lang:master Mar 19, 2025
7 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 19, 2025
Copy link

This is an experimental post-merge analysis report. You can ignore it.

Post-merge report
What is this?

This is an experimental post-merge analysis report that shows differences in
test outcomes between the merged PR and its parent PR.

Comparing 75530e9 (parent) -> 1370611 (this PR)

Test differences

No test diffs found

@jieyouxu jieyouxu deleted the temp-disable-fuchsia branch March 19, 2025 09:29
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1370611): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.0% [3.0%, 3.0%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.0% [3.0%, 3.0%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 776.359s -> 775.384s (-0.13%)
Artifact size: 365.12 MiB -> 365.09 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants