Remove `NtExpr` and `NtLiteral` #138478

nnethercote · 2025-03-14T03:50:24Z

The next part of #124141.

rustbot · 2025-03-24T06:38:28Z

Could not assign reviewer from: petrochenkov.
User(s) petrochenkov are either the PR author, already assigned, or on vacation. Please use r? to specify someone else to assign.

nnethercote · 2025-03-24T06:38:36Z

@bors try @rust-timer queue

bors · 2025-03-24T06:39:46Z

⌛ Trying commit 7f6b06c with merge 2f5db75...

…try> Remove `NtExpr` and `NtLiteral` The next part of rust-lang#124141. r? `@petrochenkov`

nnethercote · 2025-03-24T08:09:19Z

@rustbot ready

bors · 2025-03-24T08:49:21Z

☀️ Try build successful - checks-actions
Build commit: 2f5db75 (2f5db751163ab3fb82ba7631bd9a6e6d96c870fa)

rust-timer · 2025-03-24T10:12:40Z

Finished benchmarking commit (2f5db75): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.1%, 2.1%]	52
Regressions ❌ (secondary)	4.5%	[0.2%, 23.0%]	35
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.4%, -0.2%]	9
All ❌✅ (primary)	0.5%	[0.1%, 2.1%]	52

Max RSS (memory usage)

Results (primary 1.6%, secondary -4.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.6%	[1.6%, 1.6%]	1
Regressions ❌ (secondary)	2.4%	[2.4%, 2.4%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.3%	[-12.0%, -1.5%]	13
All ❌✅ (primary)	1.6%	[1.6%, 1.6%]	1

Cycles

Results (primary 1.7%, secondary 8.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.7%	[1.6%, 1.9%]	4
Regressions ❌ (secondary)	8.5%	[1.0%, 23.5%]	18
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.7%	[1.6%, 1.9%]	4

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: missing data
Artifact size: 365.48 MiB -> 365.51 MiB (0.01%)

nnethercote · 2025-03-25T05:32:50Z

The perf regressions have been seen previously in #124141, with the NtExpr/NtLiteral changes being the most impactful. Hard to avoid, unfortunately, and deep-vector is a pathological case for this PR. The last two commits in #124141 will gain back some performance.

@rustbot label: +perf-regression-triaged

compiler/rustc_ast/src/token.rs

compiler/rustc_parse/src/parser/mod.rs

compiler/rustc_parse/src/parser/expr.rs

nnethercote · 2025-03-26T05:50:18Z

Thanks for the review. I have added two new commits addressing the comments.

@rustbot ready

nnethercote · 2025-03-27T22:38:30Z

I rebased.

@bors r=petrochenkov

bors · 2025-03-27T22:38:32Z

📌 Commit bf56100 has been approved by petrochenkov

It is now in the queue for this repository.

…etrochenkov Remove `NtExpr` and `NtLiteral` The next part of rust-lang#124141. r? `@petrochenkov`

bors · 2025-03-28T01:40:42Z

⌛ Testing commit bf56100 with merge 8eca53eb16abd601c3b76002f3df69bc464a67f7...

nnethercote · 2025-03-28T03:22:46Z

Seems unrelated to this PR.

@bors retry

bors · 2025-03-28T09:37:59Z

⌛ Testing commit bf56100 with merge de2d1da...

…etrochenkov Remove `NtExpr` and `NtLiteral` The next part of rust-lang#124141. r? `@petrochenkov`

rust-log-analyzer · 2025-03-28T10:16:40Z

The job x86_64-gnu-aux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] openssl_sys test:false 1.103
[RUSTC-TIMING] openssl test:false 8.927
[RUSTC-TIMING] libssh2_sys test:false 0.103
[RUSTC-TIMING] rusqlite test:false 172.369
rustc exited with signal: 9 (SIGKILL)
error: could not compile `rusqlite` (lib)

Caused by:
  process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc /checkout/obj/build/bootstrap/debug/rustc --crate-name rusqlite --edition=2021 /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rusqlite-0.33.0/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no --cfg 'feature="bundled"' --cfg 'feature="modern_sqlite"' --check-cfg 'cfg(docsrs,test)' --check-cfg 'cfg(feature, values("array", "backup", "blob", "buildtime_bindgen", "bundled", "bundled-full", "bundled-sqlcipher", "bundled-sqlcipher-vendored-openssl", "bundled-windows", "chrono", "collation", "column_decltype", "csv", "csvtab", "extra_check", "functions", "hooks", "i128_blob", "in_gecko", "jiff", "limits", "load_extension", "loadable_extension", "modern-full", "modern_sqlite", "preupdate_hook", "rusqlite-macros", "serde_json", "serialize", "series", "session", "sqlcipher", "time", "trace", "unlock_notify", "url", "uuid", "vtab", "wasm32-wasi-vfs", "window", "with-asan"))' -C metadata=7deed2e57e928e78 -C extra-filename=-a9522900c93258aa --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/release/deps --extern bitflags=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libbitflags-2a4e970137dd58ac.rmeta --extern fallible_iterator=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libfallible_iterator-b21daee9d7de0eab.rmeta --extern fallible_streaming_iterator=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libfallible_streaming_iterator-db72f724cff07c83.rmeta --extern hashlink=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libhashlink-08217ca57b65994a.rmeta --extern libsqlite3_sys=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/liblibsqlite3_sys-377445631c6c1524.rmeta --extern smallvec=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libsmallvec-dad273e5d0f7c253.rmeta --cap-lints allow --cfg=windows_raw_dylib -Csymbol-mangling-version=v0 -Zunstable-options '--check-cfg=cfg(bootstrap)' '--check-cfg=cfg(llvm_enzyme)' '--check-cfg=cfg(rust_analyzer)' -Zmacro-backtrace -Csplit-debuginfo=off -Clink-arg=-L/checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/lib -Clink-args=-Wl,-z,origin '-Clink-args=-Wl,-rpath,$ORIGIN/../lib' -Alinker-messages -Zunstable-options -Z binary-dep-depinfo -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/build/libsqlite3-sys-f16e9fc24a9503e2/out` (exit status: 254)
warning: build failed, waiting for other jobs to finish...
Build completed unsuccessfully in 0:31:44
make: *** [Makefile:51: check-aux] Error 1
  local time: Fri Mar 28 10:16:26 UTC 2025
  network time: Fri, 28 Mar 2025 10:16:26 GMT
##[error]Process completed with exit code 2.
Post job cleanup.

bors · 2025-03-28T10:17:19Z

💔 Test failed - checks-actions

petrochenkov · 2025-03-28T12:50:36Z

This is the same failure as the previous time (maybe due to OOM?), but let's try again.
@bors retry

bors · 2025-03-28T20:17:47Z

⌛ Testing commit bf56100 with merge 4a67d7d...

…etrochenkov Remove `NtExpr` and `NtLiteral` The next part of rust-lang#124141. r? `@petrochenkov`

rust-log-analyzer · 2025-03-28T20:54:43Z

The job x86_64-gnu-aux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] openssl_sys test:false 1.105
[RUSTC-TIMING] openssl test:false 8.902
[RUSTC-TIMING] libssh2_sys test:false 0.099
[RUSTC-TIMING] rusqlite test:false 92.598
rustc exited with signal: 9 (SIGKILL)
error: could not compile `rusqlite` (lib)

Caused by:
  process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc /checkout/obj/build/bootstrap/debug/rustc --crate-name rusqlite --edition=2021 /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rusqlite-0.33.0/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no --cfg 'feature="bundled"' --cfg 'feature="modern_sqlite"' --check-cfg 'cfg(docsrs,test)' --check-cfg 'cfg(feature, values("array", "backup", "blob", "buildtime_bindgen", "bundled", "bundled-full", "bundled-sqlcipher", "bundled-sqlcipher-vendored-openssl", "bundled-windows", "chrono", "collation", "column_decltype", "csv", "csvtab", "extra_check", "functions", "hooks", "i128_blob", "in_gecko", "jiff", "limits", "load_extension", "loadable_extension", "modern-full", "modern_sqlite", "preupdate_hook", "rusqlite-macros", "serde_json", "serialize", "series", "session", "sqlcipher", "time", "trace", "unlock_notify", "url", "uuid", "vtab", "wasm32-wasi-vfs", "window", "with-asan"))' -C metadata=7deed2e57e928e78 -C extra-filename=-a9522900c93258aa --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/release/deps --extern bitflags=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libbitflags-2a4e970137dd58ac.rmeta --extern fallible_iterator=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libfallible_iterator-b21daee9d7de0eab.rmeta --extern fallible_streaming_iterator=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libfallible_streaming_iterator-db72f724cff07c83.rmeta --extern hashlink=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libhashlink-08217ca57b65994a.rmeta --extern libsqlite3_sys=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/liblibsqlite3_sys-377445631c6c1524.rmeta --extern smallvec=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/libsmallvec-dad273e5d0f7c253.rmeta --cap-lints allow --cfg=windows_raw_dylib -Csymbol-mangling-version=v0 -Zunstable-options '--check-cfg=cfg(bootstrap)' '--check-cfg=cfg(llvm_enzyme)' '--check-cfg=cfg(rust_analyzer)' -Zmacro-backtrace -Csplit-debuginfo=off -Clink-arg=-L/checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/lib -Clink-args=-Wl,-z,origin '-Clink-args=-Wl,-rpath,$ORIGIN/../lib' -Alinker-messages -Zunstable-options -Z binary-dep-depinfo -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/build/libsqlite3-sys-f16e9fc24a9503e2/out` (exit status: 254)
warning: build failed, waiting for other jobs to finish...
Build completed unsuccessfully in 0:30:18
make: *** [Makefile:51: check-aux] Error 1
  local time: Fri Mar 28 20:54:30 UTC 2025
  network time: Fri, 28 Mar 2025 20:54:31 GMT
##[error]Process completed with exit code 2.
Post job cleanup.

bors · 2025-03-28T20:55:30Z

💔 Test failed - checks-actions

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 14, 2025

This comment has been minimized.

Sign in to view

petrochenkov self-assigned this Mar 14, 2025

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2025

nnethercote force-pushed the rm-NtExpr-NtLiteral branch from 1b55759 to 7f6b06c Compare March 24, 2025 03:38

nnethercote marked this pull request as ready for review March 24, 2025 06:38

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 24, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 24, 2025

Auto merge of rust-lang#138478 - nnethercote:rm-NtExpr-NtLiteral, r=<…

2f5db75

…try> Remove `NtExpr` and `NtLiteral` The next part of rust-lang#124141. r? `@petrochenkov`

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 24, 2025

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 24, 2025

rustbot added the perf-regression-triaged The performance regression has been triaged. label Mar 25, 2025

petrochenkov reviewed Mar 25, 2025

View reviewed changes

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2025

nnethercote force-pushed the rm-NtExpr-NtLiteral branch from 7f6b06c to 37af248 Compare March 26, 2025 05:48

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 26, 2025

Fix a problem with metavars and inner attributes.

bf56100

nnethercote force-pushed the rm-NtExpr-NtLiteral branch from 940f8ca to bf56100 Compare March 27, 2025 22:37

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 27, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 28, 2025

Auto merge of rust-lang#138478 - nnethercote:rm-NtExpr-NtLiteral, r=p…

8eca53e

…etrochenkov Remove `NtExpr` and `NtLiteral` The next part of rust-lang#124141. r? `@petrochenkov`

This comment was marked as resolved.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 28, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 28, 2025

Auto merge of rust-lang#138478 - nnethercote:rm-NtExpr-NtLiteral, r=p…

de2d1da

…etrochenkov Remove `NtExpr` and `NtLiteral` The next part of rust-lang#124141. r? `@petrochenkov`

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 28, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 28, 2025

Auto merge of rust-lang#138478 - nnethercote:rm-NtExpr-NtLiteral, r=p…

4a67d7d

…etrochenkov Remove `NtExpr` and `NtLiteral` The next part of rust-lang#124141. r? `@petrochenkov`

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove `NtExpr` and `NtLiteral` #138478

Remove `NtExpr` and `NtLiteral` #138478

nnethercote commented Mar 14, 2025 •

edited

Loading

This comment has been minimized.

rustbot commented Mar 24, 2025

nnethercote commented Mar 24, 2025

This comment has been minimized.

bors commented Mar 24, 2025

nnethercote commented Mar 24, 2025

bors commented Mar 24, 2025

rust-timer commented Mar 24, 2025

nnethercote commented Mar 25, 2025

nnethercote commented Mar 26, 2025

nnethercote commented Mar 27, 2025

bors commented Mar 27, 2025

bors commented Mar 28, 2025

This comment was marked as resolved.

This comment was marked as resolved.

nnethercote commented Mar 28, 2025

bors commented Mar 28, 2025

rust-log-analyzer commented Mar 28, 2025

bors commented Mar 28, 2025

petrochenkov commented Mar 28, 2025

bors commented Mar 28, 2025

rust-log-analyzer commented Mar 28, 2025

bors commented Mar 28, 2025

Remove NtExpr and NtLiteral #138478

Are you sure you want to change the base?

Remove NtExpr and NtLiteral #138478

Conversation

nnethercote commented Mar 14, 2025 • edited Loading

This comment has been minimized.

rustbot commented Mar 24, 2025

nnethercote commented Mar 24, 2025

This comment has been minimized.

bors commented Mar 24, 2025

nnethercote commented Mar 24, 2025

bors commented Mar 24, 2025

rust-timer commented Mar 24, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

nnethercote commented Mar 25, 2025

nnethercote commented Mar 26, 2025

nnethercote commented Mar 27, 2025

bors commented Mar 27, 2025

bors commented Mar 28, 2025

This comment was marked as resolved.

This comment was marked as resolved.

nnethercote commented Mar 28, 2025

bors commented Mar 28, 2025

rust-log-analyzer commented Mar 28, 2025

bors commented Mar 28, 2025

petrochenkov commented Mar 28, 2025

bors commented Mar 28, 2025

rust-log-analyzer commented Mar 28, 2025

bors commented Mar 28, 2025

Remove `NtExpr` and `NtLiteral` #138478

Remove `NtExpr` and `NtLiteral` #138478

nnethercote commented Mar 14, 2025 •

edited

Loading