Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

privacy: Visit types and traits in impls in type privacy lints #138317

Merged
merged 1 commit into from
Mar 25, 2025
Merged

privacy: Visit types and traits in impls in type privacy lints #138317

merged 1 commit into from
Mar 25, 2025
+55 −14

Conversation

petrochenkov
Copy link
Contributor

With one exception to avoid false positives.

Fixes the same issue as #134176.

@rustbot
Copy link
Collaborator

rustbot commented Mar 10, 2025

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 10, 2025
@petrochenkov petrochenkov mentioned this pull request Mar 10, 2025
Closed
@petrochenkov
Copy link
Contributor Author

r? compiler

@rustbot rustbot assigned estebank and unassigned cjgillot Mar 24, 2025
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 24, 2025

📌 Commit fc76f1b has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2025
TaKO8Ki added a commit to TaKO8Ki/rust that referenced this pull request Mar 24, 2025
@TaKO8Ki
Rollup merge of rust-lang#138317 - petrochenkov:libsearch3, r=compile…
0606133 
…r-errors

privacy: Visit types and traits in impls in type privacy lints

With one exception to avoid false positives.

Fixes the same issue as rust-lang#134176.
@TaKO8Ki TaKO8Ki mentioned this pull request Mar 24, 2025
Closed
@compiler-errors
Copy link
Member

Needs a rebase b/c ControlFlow became #[must_use] recently. I'll open/close to rerun CI.

@compiler-errors
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 24, 2025
@TaKO8Ki
Copy link
Member

TaKO8Ki commented Mar 24, 2025 •
edited
Loading

Hi. After merging #137449, ControlFlow is must_use, so could you fix this issue?

  error: unused `ControlFlow` that must be used
      --> compiler/rustc_privacy/src/lib.rs:1409:13
       |
  1409 |             self.visit_trait(trait_ref.instantiate_identity());
       |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       |
       = note: `-D unused-must-use` implied by `-D warnings`
       = help: to override `-D warnings` add `#[allow(unused_must_use)]`
  help: use `let _ = ...` to ignore the resulting value
       |
  1409 |             let _ = self.visit_trait(trait_ref.instantiate_identity());
       |             +++++++

rollup pull request: #138909

@rust-log-analyzer

This comment was marked as resolved.

Sign in to view
@petrochenkov
Copy link
Contributor Author

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Mar 25, 2025

📌 Commit f756304 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 25, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 25, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 25, 2025
@bors
Auto merge of rust-lang#138933 - matthiaskrgr:rollup-sjtqkoq, r=matth…
43f0014 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#135745 (Recognise new IPv6 non-global range from IETF RFC 9602)
 - rust-lang#137247 (cg_llvm: Reduce the visibility of types, modules and using declarations in `rustc_codegen_llvm`.)
 - rust-lang#138317 (privacy: Visit types and traits in impls in type privacy lints)
 - rust-lang#138581 (Abort in deadlock handler if we fail to get a query map)
 - rust-lang#138776 (coverage: Separate span-extraction from unexpansion)
 - rust-lang#138886 (Fix autofix for `self` and `self as …` in `unused_imports` lint)
 - rust-lang#138924 (Reduce `kw::Empty` usage, part 3)
 - rust-lang#138929 (Visitors track whether an assoc item is in a trait impl or an inherent impl)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 81e2275 into rust-lang:master Mar 25, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 25, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 25, 2025
@rust-timer
Unrolled build for rust-lang#138317
6dffbd4 
Rollup merge of rust-lang#138317 - petrochenkov:libsearch3, r=compiler-errors

privacy: Visit types and traits in impls in type privacy lints

With one exception to avoid false positives.

Fixes the same issue as rust-lang#134176.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.
8 participants
@petrochenkov @rustbot @compiler-errors @bors @TaKO8Ki @rust-log-analyzer @estebank @cjgillot