Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use struct tail rather than metadata projection to compute coercion fast path #138292

Closed

Conversation

compiler-errors
Copy link
Member

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 9, 2025
@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 9, 2025
@compiler-errors compiler-errors marked this pull request as draft March 9, 2025 23:13
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 9, 2025
…r=<try>

Use struct tail rather than metadata projection to compute coercion fast path

cc rust-lang#136127 (comment)

r? `@ghost`
@bors
Copy link
Collaborator

bors commented Mar 9, 2025

⌛ Trying commit b4cee9b with merge fbd9a21...

@bors
Copy link
Collaborator

bors commented Mar 10, 2025

☀️ Try build successful - checks-actions
Build commit: fbd9a21 (fbd9a21cdbc244602badb8908a529ff58579acfc)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fbd9a21): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.5% [-0.8%, -0.2%] 23
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.0% [2.0%, 2.0%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.0% [2.0%, 2.0%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 770.102s -> 768.521s (-0.21%)
Artifact size: 361.98 MiB -> 361.98 MiB (-0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 10, 2025
@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 10, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 10, 2025
…r=<try>

Use struct tail rather than metadata projection to compute coercion fast path

cc rust-lang#136127 (comment)

r? `@ghost`
@bors
Copy link
Collaborator

bors commented Mar 10, 2025

⌛ Trying commit 8ff333e with merge 19ae219...

@bors
Copy link
Collaborator

bors commented Mar 10, 2025

☀️ Try build successful - checks-actions
Build commit: 19ae219 (19ae2193b48a0d96abbd3d3ba745b99a240a14e0)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (19ae219): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.9% [-3.3%, -0.2%] 92
Improvements ✅
(secondary)
-3.7% [-11.5%, -0.5%] 68
All ❌✅ (primary) -0.9% [-3.3%, -0.2%] 92

Max RSS (memory usage)

Results (primary 0.9%, secondary -4.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.0% [3.0%, 3.0%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.1% [-1.1%, -1.1%] 1
Improvements ✅
(secondary)
-4.4% [-6.7%, -1.9%] 7
All ❌✅ (primary) 0.9% [-1.1%, 3.0%] 2

Cycles

Results (primary -1.9%, secondary -5.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.1% [4.0%, 4.2%] 2
Improvements ✅
(primary)
-1.9% [-4.0%, -1.0%] 18
Improvements ✅
(secondary)
-6.4% [-12.0%, -1.9%] 31
All ❌✅ (primary) -1.9% [-4.0%, -1.0%] 18

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 779.823s -> 777.929s (-0.24%)
Artifact size: 365.18 MiB -> 365.13 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 10, 2025
@compiler-errors
Copy link
Member Author

i have to rework how we emit diagnostics here i guess

@WaffleLapkin
Copy link
Member

WaffleLapkin commented Mar 13, 2025

@rustbot author
based on the last comment and draft status

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 13, 2025
@compiler-errors
Copy link
Member Author

not sure who the relabeling is for given this isn't assigned to anyone 🤔

@WaffleLapkin
Copy link
Member

WaffleLapkin commented Mar 13, 2025

I'm eepy and thought I'm assigned to this (was confused by reviewer suggestions). Oops /_=

@compiler-errors
Copy link
Member Author

anyways this pr was a failed experiment and is superseded by a more involved change in #138438

@compiler-errors compiler-errors deleted the coercion-fast-path branch March 13, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants