Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: adapt for LLVM 21 changes #137818

Merged
merged 1 commit into from
Mar 2, 2025
Merged

tests: adapt for LLVM 21 changes #137818

merged 1 commit into from
Mar 2, 2025

Conversation

durin42
Copy link
Contributor

@durin42 durin42 commented Feb 28, 2025

Per discussion in #137799 we don't really need this readonly attribute, so let's just drop it so the test passes on LLVM 21.

Fixes #137799.

@durin42
tests: adapt for LLVM 21 changes
2d3639d 
Per discussion in rust-lang#137799 we don't really need this readonly attribute,
so let's just drop it so the test passes on LLVM 21.

Fixes rust-lang#137799.
@rustbot
Copy link
Collaborator

rustbot commented Feb 28, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 28, 2025
jieyouxu
jieyouxu approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you can r=me once PR CI is green.

@jieyouxu jieyouxu assigned jieyouxu and unassigned Mark-Simulacrum Feb 28, 2025
@jieyouxu
Copy link
Member

Actually nvm.
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 28, 2025

📌 Commit 2d3639d has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 28, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 1, 2025
@matthiaskrgr
Rollup merge of rust-lang#137818 - durin42:llvm-21-remove-readonly, r…
962f4e2 
…=jieyouxu

tests: adapt for LLVM 21 changes

Per discussion in rust-lang#137799 we don't really need this readonly attribute, so let's just drop it so the test passes on LLVM 21.

Fixes rust-lang#137799.
This was referenced Mar 1, 2025
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 1, 2025
@bors
Auto merge of rust-lang#137855 - matthiaskrgr:rollup-uh7f3fi, r=matth…
d264161 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#137804 (rename BackendRepr::Vector → SimdVector)
 - rust-lang#137807 (Fully qualify `Result` in generated doctest code)
 - rust-lang#137809 (Use correct error message casing for `io::const_error`s)
 - rust-lang#137818 (tests: adapt for LLVM 21 changes)
 - rust-lang#137822 (Update query normalizer docs to not position it as the greatest pioneer in the space of normalization)
 - rust-lang#137824 (Tweak invalid RTN errors)
 - rust-lang#137828 (Fix inaccurate `std::intrinsics::simd` documentation)
 - rust-lang#137830 (Fix link failure on AVR (incompatible ISA error))
 - rust-lang#137837 (Update `const_conditions` and `explicit_implied_const_bounds` docs)
 - rust-lang#137840 (triagebot: only ping me for constck)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 2, 2025
@bors
Auto merge of rust-lang#137855 - matthiaskrgr:rollup-uh7f3fi, r=matth…
1c3b035 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#137804 (rename BackendRepr::Vector → SimdVector)
 - rust-lang#137807 (Fully qualify `Result` in generated doctest code)
 - rust-lang#137809 (Use correct error message casing for `io::const_error`s)
 - rust-lang#137818 (tests: adapt for LLVM 21 changes)
 - rust-lang#137822 (Update query normalizer docs to not position it as the greatest pioneer in the space of normalization)
 - rust-lang#137824 (Tweak invalid RTN errors)
 - rust-lang#137828 (Fix inaccurate `std::intrinsics::simd` documentation)
 - rust-lang#137830 (Fix link failure on AVR (incompatible ISA error))
 - rust-lang#137837 (Update `const_conditions` and `explicit_implied_const_bounds` docs)
 - rust-lang#137840 (triagebot: only ping me for constck)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 224ea37 into rust-lang:master Mar 2, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 2, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 2, 2025
@rust-timer
Unrolled build for rust-lang#137818
de1d677 
Rollup merge of rust-lang#137818 - durin42:llvm-21-remove-readonly, r=jieyouxu

tests: adapt for LLVM 21 changes

Per discussion in rust-lang#137799 we don't really need this readonly attribute, so let's just drop it so the test passes on LLVM 21.

Fixes rust-lang#137799.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.

LLVM 21: issue-114312.rs fails after llvm-project@36f0838a3dd1
5 participants
@durin42 @rustbot @jieyouxu @bors @Mark-Simulacrum