-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle autodiff for lib builds #137570
base: master
Are you sure you want to change the base?
Handle autodiff for lib builds #137570
Conversation
This comment has been minimized.
This comment has been minimized.
5b8038c
to
f9f5959
Compare
The third (iffy) commit let's me compile and run the thin-lto pipeline for dependencies, but it runs into the following assertion:
Removing the assertion runs into the next one:
That sounds like an assertion which I probably shouldn't touch. I would have preferred to just support thin-lto instead of having to alter the compilation pipeline even more and move all other workers to fat-lto, since I was worried that would break other assumptions. But it might be easier, I'll look more into it. The enforcing of fat-lto should be coupled to the user setting |
The job Click to see the possible cause of the failure (guessed by this bot)
|
☔ The latest upstream changes (presumably #138177) made this pull request unmergeable. Please resolve the merge conflicts. |
@rustbot label +F-autodiff |
Work in Progress.
Tracking:
r? @oli-obk