-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As per issue #136827 submitting updates to E0495 documentation #137042
base: master
Are you sure you want to change the base?
As per issue #136827 submitting updates to E0495 documentation #137042
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Noratrieb (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
The job Click to see the possible cause of the failure (guessed by this bot)
|
@@ -1,40 +1,36 @@ | |||
#### Note: this error code is no longer emitted by the compiler. | |||
A trait implementation returns a reference without an explicit lifetime linking it to `self`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is what this error stands for, I think this is a much more generic lifetime error from searching for the code in ./tests
.
I would probably just keep the old documentation, it's not amazing but I don't think it's possible to write documentation with great examples for this error code, it just seems like this is a very generic error code emitted in all sorts of cases.
@compiler-errors maybe you know more about this error code and whether what I said is correct. (emitted here
fn report_inference_failure(&self, var_origin: RegionVariableOrigin) -> Diag<'_> { |
@progressive-galib thank you for the PR, I've left some feedback on the contents. As this is your first PR, some tips on how to best write a PR title and description: This fixes an issue, and if you leave Don't worry about getting it wrong here, it's fine, you can update it here and for next time :). |
@progressive-galib can you have a look at the latest feedback when you have a moment? Switching to waiting on author to incorporate changes. Feel free to request a review with @rustbot author |
documentation updated