Skip to content

[compiletest-related cleanups 4/7] Make the distinction between root build directory vs test suite specific build directory in compiletest less confusing #136542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2025
Merged

[compiletest-related cleanups 4/7] Make the distinction between root build directory vs test suite specific build directory in compiletest less confusing #136542

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d6a6e7
compiletest: disambiguate between root build dir vs test suite specif…
jieyouxu Feb 4, 2025
5238337
bootstrap: remove `--build-base` and use `--build-root` and `--build-…
jieyouxu Feb 4, 2025
7d2e4e4
bootstrap: remove redundant `to_path_buf()`
jieyouxu Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
bootstrap: remove redundant to_path_buf()
  • Loading branch information
@jieyouxu
jieyouxu committed Feb 23, 2025
commit 7d2e4e4b6966ae4646e4f87800dafe6cc1b839c2
2 changes: 1 addition & 1 deletion src/bootstrap/src/core/build_steps/test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1785,7 +1785,7 @@ NOTE: if you're sure you want to do this, please open an issue as to why. In the
let sysroot = if builder.top_stage == 0 {
builder.initial_sysroot.clone()
} else {
builder.sysroot(compiler).to_path_buf()
builder.sysroot(compiler)
};

cmd.arg("--sysroot-base").arg(sysroot);
Expand Down
Loading