-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc-json: Precise capturing JSON is untyped #137616
Labels
A-rustdoc-json
Area: Rustdoc JSON backend
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
E-medium
Call for participation: Medium difficulty. Experience needed to fix: Intermediate.
E-mentor
Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
F-precise_capturing
`#![feature(precise_capturing)]`
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Comments
By the time it's in But the distinction does exist in Hir: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_hir/hir/enum.GenericBound.html So a fix to this would need to:
|
@rustbot claim |
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this issue
Mar 10, 2025
…turing-arg, r=aDotInTheVoid,compiler-errors make precise capturing args in rustdoc Json typed close rust-lang#137616 This PR includes below changes. - Add `rustc_hir::PreciseCapturingArgKind` which allows the query system to return a arg's data. - Add `rustdoc::clean::types::PreciseCapturingArg` and change to use it. - Add `rustdoc-json-types::PreciseCapturingArg` and change to use it. - Update `tests/rustdoc-json/impl-trait-precise-capturing.rs`. - Bump `rustdoc_json_types::FORMAT_VERSION`.
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this issue
Mar 10, 2025
…turing-arg, r=aDotInTheVoid,compiler-errors make precise capturing args in rustdoc Json typed close rust-lang#137616 This PR includes below changes. - Add `rustc_hir::PreciseCapturingArgKind` which allows the query system to return a arg's data. - Add `rustdoc::clean::types::PreciseCapturingArg` and change to use it. - Add `rustdoc-json-types::PreciseCapturingArg` and change to use it. - Update `tests/rustdoc-json/impl-trait-precise-capturing.rs`. - Bump `rustdoc_json_types::FORMAT_VERSION`.
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this issue
Mar 11, 2025
…turing-arg, r=aDotInTheVoid,compiler-errors make precise capturing args in rustdoc Json typed close rust-lang#137616 This PR includes below changes. - Add `rustc_hir::PreciseCapturingArgKind` which allows the query system to return a arg's data. - Add `rustdoc::clean::types::PreciseCapturingArg` and change to use it. - Add `rustdoc-json-types::PreciseCapturingArg` and change to use it. - Update `tests/rustdoc-json/impl-trait-precise-capturing.rs`. - Bump `rustdoc_json_types::FORMAT_VERSION`.
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this issue
Mar 11, 2025
…turing-arg, r=aDotInTheVoid,compiler-errors make precise capturing args in rustdoc Json typed close rust-lang#137616 This PR includes below changes. - Add `rustc_hir::PreciseCapturingArgKind` which allows the query system to return a arg's data. - Add `rustdoc::clean::types::PreciseCapturingArg` and change to use it. - Add `rustdoc-json-types::PreciseCapturingArg` and change to use it. - Update `tests/rustdoc-json/impl-trait-precise-capturing.rs`. - Bump `rustdoc_json_types::FORMAT_VERSION`.
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this issue
Mar 12, 2025
…turing-arg, r=aDotInTheVoid,compiler-errors make precise capturing args in rustdoc Json typed close rust-lang#137616 This PR includes below changes. - Add `rustc_hir::PreciseCapturingArgKind` which allows the query system to return a arg's data. - Add `rustdoc::clean::types::PreciseCapturingArg` and change to use it. - Add `rustdoc-json-types::PreciseCapturingArg` and change to use it. - Update `tests/rustdoc-json/impl-trait-precise-capturing.rs`. - Bump `rustdoc_json_types::FORMAT_VERSION`.
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this issue
Mar 12, 2025
…turing-arg, r=aDotInTheVoid,compiler-errors make precise capturing args in rustdoc Json typed close rust-lang#137616 This PR includes below changes. - Add `rustc_hir::PreciseCapturingArgKind` which allows the query system to return a arg's data. - Add `rustdoc::clean::types::PreciseCapturingArg` and change to use it. - Add `rustdoc-json-types::PreciseCapturingArg` and change to use it. - Update `tests/rustdoc-json/impl-trait-precise-capturing.rs`. - Bump `rustdoc_json_types::FORMAT_VERSION`.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Mar 13, 2025
…turing-arg, r=aDotInTheVoid,compiler-errors make precise capturing args in rustdoc Json typed close rust-lang#137616 This PR includes below changes. - Add `rustc_hir::PreciseCapturingArgKind` which allows the query system to return a arg's data. - Add `rustdoc::clean::types::PreciseCapturingArg` and change to use it. - Add `rustdoc-json-types::PreciseCapturingArg` and change to use it. - Update `tests/rustdoc-json/impl-trait-precise-capturing.rs`. - Bump `rustdoc_json_types::FORMAT_VERSION`.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Mar 13, 2025
…turing-arg, r=aDotInTheVoid,compiler-errors make precise capturing args in rustdoc Json typed close rust-lang#137616 This PR includes below changes. - Add `rustc_hir::PreciseCapturingArgKind` which allows the query system to return a arg's data. - Add `rustdoc::clean::types::PreciseCapturingArg` and change to use it. - Add `rustdoc-json-types::PreciseCapturingArg` and change to use it. - Update `tests/rustdoc-json/impl-trait-precise-capturing.rs`. - Bump `rustdoc_json_types::FORMAT_VERSION`.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Mar 13, 2025
Rollup merge of rust-lang#138109 - Kohei316:feat/rust-doc-precise-capturing-arg, r=aDotInTheVoid,compiler-errors make precise capturing args in rustdoc Json typed close rust-lang#137616 This PR includes below changes. - Add `rustc_hir::PreciseCapturingArgKind` which allows the query system to return a arg's data. - Add `rustdoc::clean::types::PreciseCapturingArg` and change to use it. - Add `rustdoc-json-types::PreciseCapturingArg` and change to use it. - Update `tests/rustdoc-json/impl-trait-precise-capturing.rs`. - Bump `rustdoc_json_types::FORMAT_VERSION`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-rustdoc-json
Area: Rustdoc JSON backend
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
E-medium
Call for participation: Medium difficulty. Experience needed to fix: Intermediate.
E-mentor
Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
F-precise_capturing
`#![feature(precise_capturing)]`
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Given this function:
we can see this rustdoc JSON for the function output type:
Note that the
use
data is completely untyped and just raw strings:We probably want to use different JSON types at least for generic args and lifetimes before we stabilize the format.
Right now cargo-public-api resorts to a "if string begins with
'
" hack.The text was updated successfully, but these errors were encountered: