fix: Properly calculate the max line num for suggestions #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
reviewed
Oct 20, 2025
epage
reviewed
Oct 20, 2025
src/snippet.rs
Outdated
|
|
||
| /// A whitespace [`Element`] in a [`Group`] | ||
| #[derive(Clone, Debug)] | ||
| #[derive(Clone, Copy, Debug)] |
There was a problem hiding this comment.
Are we sure we want to have this from an API perspective?
There was a problem hiding this comment.
It is probably something we should put more thought into, so I will drop it from this PR.
epage
approved these changes
Oct 20, 2025
Muscraft
force-pushed
the
fix-suggestion-max-line-num
branch
from
526149a to
8e9817b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some cases where we were not calculating the correct max line number for suggests, this PR addresses those problems.