Switch to esbuild. Closes #14. #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeger
force-pushed
the
esbuild
branch
3 times, most recently
from
038be29 to
1945868
Compare
xeger
changed the title
kddnewton
reviewed
Jul 22, 2022
Member
|
Shoot, merging the other one makes this conflict. @xeger can you resolve? |
Contributor
Author
|
Done @kddnewton. Note that job names are changing, so you will need to edit required checks for branch protection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was easy enough to follow the Microsofft instructions.
Per instructions on the web page, we are compiling the extension and its tests using tsc, but building for distribution using esbuild ... that means we're not testing what we plan to ship!
I tried to use
esbuildfor the tests and gave up after an hour; that's just not what it's designed for. I also tried to split the duties, compiling tests withtscand the extension withesbuild; this somewhat works, but it makes things more complicated and I couldn't quite figure out how to suppress TSC's version of the extension & friends.The hybrid approach is ideal (test what we ship) and could probably be accomplished with more fiddling. For now, I've just given up and added a 2nd job,
buildto prove that esbuild works, while thecijob has becometestand it exclusively uses tsc.P.S. I notice that I converted all tabs to spaces, in the JSON files I touched. This is VS Code's choice, apparently driven by some local setting. Do you have a preference for JSON in this repo? We should add an
.editorconfigand/or a forced setting under.vscodeto ensure harmony.