Introduce new node SyntaxTree::HeredocEnd
#95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildmaples
force-pushed
the
heredoc-end
branch
2 times, most recently
from
1a8b06f to
29ef274
Compare
|
Fixed the changes we discussed: remove the adding of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
As I mentioned on Slack, currently we only have access to
SyntaxTree::HeredocBegwhich only gives us the opening HEREDOC delimiter. The closing delimiter is only provided as a String inSyntaxTree::Heredoc. Having aSyntaxTree::HeredocEndnode for the closing delimiter's location would be helpful.Then, we won't have to do the calculations ourselves and seems more consistent with the existence of
HeredocBeg.Changes
I followed the way
HeredocBegwas implemented and added tests.