Skip to content

Fix WithScope visits for deconstructed block params #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2023
Merged

Fix WithScope visits for deconstructed block params #328

merged 1 commit into from
Mar 2, 2023

Conversation

@vinistock
Copy link
Contributor

@vinistock vinistock commented Mar 2, 2023

Deconstructed block parameters using splats were passing an ArgStar instead of an Ident to add_local_definition resulting in a no method delete_suffix error.

Also added more tests!

kddnewton
kddnewton requested changes Mar 2, 2023
View reviewed changes
@vinistock @kddnewton
Fix WithScope visits for deconstructed block params
77bdc12 
Co-authored-by: Kevin Newton <kddnewton@users.noreply.github.com>
@vinistock vinistock force-pushed the vs/fix_deconstructed_block_params branch from 7c8870d to 77bdc12 Compare March 2, 2023 22:16
@kddnewton kddnewton merged commit 1510e4f into ruby-syntax-tree:main Mar 2, 2023
@vinistock vinistock deleted the vs/fix_deconstructed_block_params branch March 3, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kddnewton kddnewton kddnewton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vinistock @kddnewton