Combine LambdaVar node with BlockVar
#303
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egiurleo
commented
Feb 9, 2023
kddnewton
requested changes
Feb 26, 2023
egiurleo
commented
Mar 23, 2023
| q.text("|") | ||
| q.group do | ||
| q.remove_breaks(q.format(params)) | ||
| pipe? ? q.remove_breaks(q.format(params)) : q.format(params) |
Contributor
Author
There was a problem hiding this comment.
I managed to move the first two lines of this method into BlockNode, but I"m having trouble with q.remove_breaks because the tests seem to expect that all params within pipes are on the same line. Any suggestions?
Both `LambdaVar` and `BlockVar` represent a collection of arguments (positional, optional, keyword, block) as well as block or lambda-local variables. This commit removes the `LambdaVar` node and folds its functionality into the `BlockVar` node, which reduces the number of nodes and simplifies logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #278.
This PR combines the
LambdaVarnode withBlockVar. Now, any params on blocks or lambdas will be represented by aBlockVarnode. This removes an unnecessary node from syntax tree, which simplifies logic and brings syntax tree closer to other Ruby AST implementations.