Introduce plugin/disable_ternary
#250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtaylorhq
force-pushed
the
disable-ternary-plugin
branch
from
f483345 to
e3715ca
Compare
This will prevent the automatic conversion of `if ... else` to ternary expressions.
auto-merge was automatically disabled
January 26, 2023 16:22
Head branch was pushed to by a user without write access
davidtaylorhq
force-pushed
the
disable-ternary-plugin
branch
from
e3715ca to
82dc9b7
Compare
Contributor
Author
|
(fixed up the test failure - sorry about that!) |
Member
|
No worries. I like this plugin and intend to support it, but |
Contributor
Author
|
Hi @kddnewton, would it be possible to get a syntax_tree release with the official version of this plugin? We'd love to move away from our gem-based implementation at Discourse. |
Member
|
Oh no! I thought I did. Sorry about that! |
Member
|
Should be out, let me know if you have problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent the automatic conversion of
if ... elseto ternary expressions.