Skip to content

YARV refactor #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Nov 22, 2022
Merged

YARV refactor #214

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
f40ae12
Move compiler to its own file
kddnewton Nov 19, 2022
8b836c7
Split YARV out into its own file
kddnewton Nov 19, 2022
6c6b88b
Start the disassembler
kddnewton Nov 19, 2022
c9db96b
opt_mult, Float, and Rational
kddnewton Nov 19, 2022
8ad799a
Local variables and assignments
kddnewton Nov 19, 2022
0047065
Inline builder into ISeq
kddnewton Nov 19, 2022
154e75f
Put child iseq methods on iseq
kddnewton Nov 21, 2022
df9f622
Test out disassembler
kddnewton Nov 21, 2022
6c6b437
Add BF compiler
kddnewton Nov 21, 2022
a1236fd
Default to VM_CALL_ARGS_SIMPLE
kddnewton Nov 21, 2022
d8815de
Add objects to wrap instructions
kddnewton Nov 21, 2022
441bc01
opt_aref_with
kddnewton Nov 22, 2022
cc24d7f
opt_aset_with
kddnewton Nov 22, 2022
5bd3463
setblockparam
kddnewton Nov 22, 2022
f35c452
setspecial
kddnewton Nov 22, 2022
1262b52
newarraykwsplat
kddnewton Nov 22, 2022
d4d7f0b
Pattern match for arrays
kddnewton Nov 22, 2022
5abcb5a
Handle => operator for rightward assignment
kddnewton Nov 22, 2022
8a0f1ec
Create Legacy module for legacy YARV instructions
kddnewton Nov 22, 2022
ba8cad0
More instructions to classes
kddnewton Nov 22, 2022
b6fb92e
Get it working on TruffleRuby
kddnewton Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Create Legacy module for legacy YARV instructions
  • Loading branch information
@kddnewton
kddnewton committed Nov 22, 2022
commit 8a0f1ecc1eae2943d50a3a86473ffc2c329e27be
24 changes: 12 additions & 12 deletions lib/syntax_tree/compiler.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,18 +870,18 @@ def visit_defined(node)
case value
when Const
iseq.putnil
iseq.defined(YARV::Defined::CONST, name, "constant")
iseq.defined(YARV::Defined::TYPE_CONST, name, "constant")
when CVar
iseq.putnil
iseq.defined(YARV::Defined::CVAR, name, "class variable")
iseq.defined(YARV::Defined::TYPE_CVAR, name, "class variable")
when GVar
iseq.putnil
iseq.defined(YARV::Defined::GVAR, name, "global-variable")
iseq.defined(YARV::Defined::TYPE_GVAR, name, "global-variable")
when Ident
iseq.putobject("local-variable")
when IVar
iseq.putnil
iseq.defined(YARV::Defined::IVAR, name, "instance-variable")
iseq.defined(YARV::Defined::TYPE_IVAR, name, "instance-variable")
when Kw
case name
when :false
Expand All @@ -898,13 +898,13 @@ def visit_defined(node)
iseq.putself

name = node.value.value.value.to_sym
iseq.defined(YARV::Defined::FUNC, name, "method")
iseq.defined(YARV::Defined::TYPE_FUNC, name, "method")
when YieldNode
iseq.putnil
iseq.defined(YARV::Defined::YIELD, false, "yield")
iseq.defined(YARV::Defined::TYPE_YIELD, false, "yield")
when ZSuper
iseq.putnil
iseq.defined(YARV::Defined::ZSUPER, false, "super")
iseq.defined(YARV::Defined::TYPE_ZSUPER, false, "super")
else
iseq.putobject("expression")
end
Expand Down Expand Up @@ -1875,24 +1875,24 @@ def opassign_defined(node)
name = node.target.constant.value.to_sym

iseq.dup
iseq.defined(YARV::Defined::CONST_FROM, name, true)
iseq.defined(YARV::Defined::TYPE_CONST_FROM, name, true)
when TopConstField
name = node.target.constant.value.to_sym

iseq.putobject(Object)
iseq.dup
iseq.defined(YARV::Defined::CONST_FROM, name, true)
iseq.defined(YARV::Defined::TYPE_CONST_FROM, name, true)
when VarField
name = node.target.value.value.to_sym
iseq.putnil

case node.target.value
when Const
iseq.defined(YARV::Defined::CONST, name, true)
iseq.defined(YARV::Defined::TYPE_CONST, name, true)
when CVar
iseq.defined(YARV::Defined::CVAR, name, true)
iseq.defined(YARV::Defined::TYPE_CVAR, name, true)
when GVar
iseq.defined(YARV::Defined::GVAR, name, true)
iseq.defined(YARV::Defined::TYPE_GVAR, name, true)
end
end

Expand Down
4 changes: 2 additions & 2 deletions lib/syntax_tree/yarv.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,14 +434,14 @@ def getblockparamproxy(index, level)

def getclassvariable(name)
if RUBY_VERSION < "3.0"
push(GetClassVariableUncached.new(name))
push(Legacy::GetClassVariable.new(name))
else
push(GetClassVariable.new(name, inline_storage_for(name)))
end
end

def getconstant(name)
push(GetConstant.new(name))
push(Legacy::GetConstant.new(name))
end

def getglobal(name)
Expand Down
Loading