Skip to content

Performance #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 17, 2022
Merged

Performance #170

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3150301
Tons of various performance tweaks
kddnewton Oct 16, 2022
ed0c475
Split up find_token options into more explicit variants
kddnewton Oct 16, 2022
840ebab
Even more performance tweaks
kddnewton Oct 16, 2022
b5d226b
Move lambdas into their own methods, smarter token finding in on_args…
kddnewton Oct 17, 2022
7b6dbeb
More micro-optimizations
kddnewton Oct 17, 2022
929726b
Remove remaining pattern matching
kddnewton Oct 17, 2022
b5154ac
each_line instead of split
kddnewton Oct 17, 2022
e31dded
Update the prettier_print version
kddnewton Oct 17, 2022
b117c9b
Fix message checking accidentally introduced when removing pattern ma…
kddnewton Oct 17, 2022
f5ac5fe
Reformat
kddnewton Oct 17, 2022
95b2584
Fix incorrect logic in forced_brace_bounds? translation
kddnewton Oct 17, 2022
89081df
Fix up rubocop violations
kddnewton Oct 17, 2022
8f15bbb
Check if this is working on truffleruby
kddnewton Oct 17, 2022
aa0573d
Fix incorrect translation of Ternaryable.call
kddnewton Oct 17, 2022
7b2bc9b
Remove truffleruby from tests until we finish removing pattern matching
kddnewton Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix incorrect translation of Ternaryable.call
  • Loading branch information
@kddnewton
kddnewton committed Oct 17, 2022
commit aa0573ddc919c18d641b71757571805c780a3d3a
2 changes: 1 addition & 1 deletion lib/syntax_tree/node.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5396,7 +5396,7 @@ def ternaryable?(statement)
# operators, then we can't use a ternary expression as it would break
# the flow control.
operator = statement.operator
operator != "and" && operator != "or"
operator != :and && operator != :or
else
true
end
Expand Down