refactor: Improve how whitespace is consumed in complex selectors #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
flavorjones-complex-selector-whitespace
branch
from
987a9b1 to
9dcf7c0
Compare
Collaborator
Author
|
Converted to draft since I think there may be a better way to do this, please hold for a second PR that provides another option. |
Collaborator
Author
|
See #61 which I think I like better. |
kddnewton
approved these changes
Jun 5, 2024
flavorjones
force-pushed
the
flavorjones-complex-selector-whitespace
branch
from
9dcf7c0 to
c2b5853
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday we discussed the oddness of how I consumed whitespace in an earlier PR, and I think this is a better choice. Would love feedback.
Existing test coverage exists to prevent regressions.