Skip to content

change NavigationNativeContainer to NavigationContainer #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

broerjuang
Copy link
Contributor

When I try to use package from v5/bs7 I encounter following issue

Simulator Screen Shot - iPhone X - 2020-02-12 at 18 25 13

so this diff will try to fix the issue

Comment on lines +107 to 108
"NavigationContainer";
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename the module and deprecate the old name?

module NavigationContainer = {
  type state = Js.Json.t;
  type navigationState = state => unit;

  [@bs.module "@react-navigation/native"] [@react.component]
  external make:
    (
      ~initialState: state=?,
      ~onStateChange: navigationState=?,
      ~children: React.element
    ) =>
    React.element =
    "NavigationContainer";
};

[@ocaml.deprecated "Use NavigationContainer instead."]
module NavigationNativeContainer = NavigationContainer;

@MoOx MoOx closed this in d2b033f Feb 28, 2020
@MoOx
Copy link
Member

MoOx commented Feb 28, 2020

Thanks for the help. This wasn't complete but I merged your work in d2b033f with the help of @DCKT from #26 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants