Skip to content

Add defaultNavigationOptions params to StackNavigator config #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2019
Merged

Add defaultNavigationOptions params to StackNavigator config #12

merged 1 commit into from
Nov 1, 2019

Conversation

DCKT
Copy link
Contributor

@DCKT DCKT commented Oct 29, 2019

Hello,

I just add a new param, it might be cool in the future to have a NavigationOptions.t for each navigator (in order to avoid bad props).

@DCKT DCKT added the enhancement New feature or request label Oct 29, 2019
@DCKT DCKT requested a review from MoOx October 29, 2019 18:30
@DCKT DCKT self-assigned this Oct 29, 2019
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

A PR adding defaultNavigationOptions to the other navigators where it is missing would be most welcome, too.

@cknitt cknitt merged commit 0406d33 into rescript-react-native:master Nov 1, 2019
@DCKT
Copy link
Contributor Author

DCKT commented Nov 1, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants