Skip to content

Update to use the actual script names in templates #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

esthor
Copy link
Contributor

@esthor esthor commented Dec 20, 2019

otherwise this can be confusing, because the "start:ios" and "start:android" do not exist in the package.json scripts in the template. note: just running "yarn ios" or "yarn android" will kick off the metro bundler anyway if it's not already running :)

This is only a documentation edit.

Closes #

otherwise this can be confusing, because the "start:ios" and "start:android" do not exist in the package.json scripts in the template. note: just running "yarn ios" or "yarn android" will kick off the metro bundler anyway if it's not already running :)
Copy link
Member

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@MoOx MoOx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MoOx MoOx merged commit 721ca90 into rescript-react-native:src Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants