Skip to content

Create .gitattributes #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2020
Merged

Create .gitattributes #13

merged 3 commits into from
Feb 18, 2020

Conversation

smorimoto
Copy link
Contributor

No description provided.

Copy link
Member

@MoOx MoOx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @imbsky, sorry for the delay for responding.

What is the * text part for? Ideally I would like the org to have the same kind of things for all repo, so if there is a real benefit for this change we could apply it in the template repo & so to the others.
That said, the link you mentioned is from 2012, is it still relevant to add this in 2020?

To facilitate the review for your upcoming PR, do not hesitate to explain motivation. I know I may sound silly, especially for simple diff like that, but without a proper description on the reason, it's hard to know what is it for :D

@smorimoto
Copy link
Contributor Author

In other words, it's a config for the conversion of newline characters, and to some extent a matter of taste. I didn't have a very strong opinion about that so I removed it.

@MoOx MoOx merged commit 2ca2b74 into rescript-react-native:src Feb 18, 2020
@MoOx
Copy link
Member

MoOx commented Feb 18, 2020

Thanks again!

@smorimoto smorimoto deleted the patch-1 branch February 18, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants