Skip to content

Fix highlighting for nested multiline comments #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2021

Conversation

amiralies
Copy link
Collaborator

Closes #21

@amiralies amiralies requested a review from ryyppy January 14, 2021 23:15
@amiralies
Copy link
Collaborator Author

amiralies commented Jan 14, 2021

This is a quick fix. I didn't find any major mis-highlighting. Can you give it a try @ryyppy ?
I think we can improve this when we introduced rescript's doc comments

@ryyppy
Copy link
Member

ryyppy commented Jan 15, 2021

yeah i will try it. Thanks for proposing the change!

@ryyppy
Copy link
Member

ryyppy commented Jan 15, 2021

Seems like there is an edge-case when using // within /**/ in the same line:

image

@amiralies
Copy link
Collaborator Author

Fixed!

@ryyppy
Copy link
Member

ryyppy commented Jan 21, 2021

Looking good so far (have been using it for quite a while now). I will extend my usage for a few more days just to be sure that everything is working correctly.

Copy link
Member

@ryyppy ryyppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had a fair share testing this, I am fine getting this merged with an appropriate Changelog update

@amiralies amiralies merged commit 32f70fa into master Feb 1, 2021
@ryyppy ryyppy deleted the fix-nested-comments branch February 1, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax highlighting for nested /* */ broken
2 participants