-
-
Notifications
You must be signed in to change notification settings - Fork 15
Fixes #17 - Support for Monorepos using Yarn Workspaces #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
interesting, will need to try that. do you have any public yarn workspaces / rescript repo where I can test this myself? |
I do not have any public repos using yarn workspaces, but I can certainly create an example repo if need be. Let me know if that is something you would like me to do for testing purposes. |
yeah, maybe create an examples/monorepo folder within this PR so we can keep it around for integration testing later on? |
Just pushed up a quick and simple example for a monorepo @ryyppy - Let me know if this helps.
|
Thanks. I needed to simplify your example and add some other stuff, so I will close this PR in favour of #19 |
Sounds good. |
@dan003400 We still need to coordinate with Bob if this is the correct way to detect tooling from a compiler perspective. For now we will keep the aforementioned PR (#19) in a draft state. Closing this PR. |
I took a look how the path is defined when sourcing the binaries and this seems to keep looking up until the
node_modules
directory is found that also includes abs-platform
directory.Let me know if anyone sees any issues with this, I tried this both on a monorepo project and a traditional project and it seems to work for both projects.