Skip to content

Syntax: Add support for string interpolation #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amiralies opened this issue Jun 14, 2021 · 2 comments · Fixed by #44
Closed

Syntax: Add support for string interpolation #43

amiralies opened this issue Jun 14, 2021 · 2 comments · Fixed by #44

Comments

@amiralies
Copy link
Collaborator

I'm not sure about the grammar maybe take a look at syntax repo.
do we have $name or just ${name}?
@amiralies amiralies mentioned this issue Jun 15, 2021
Merged
@ryyppy
Copy link
Member

ryyppy commented Jul 6, 2021

$name should theoretically highlight as well, but I think we'd rather nudge ppl to always use the ${name} variant, since the former requires you to use the j` prefix.

@amiralies
Copy link
Collaborator Author

Added back single var syntax in pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add string interpolation syntax rescript-lang/vim-rescript
2 participants
@ryyppy @amiralies