JSX v4 record-based representation for lowercase

[mununki]

This PR changes the internal representation of JSX v4 lowercase e.g. <div /> from object to record

[mununki]

@cristianoc What about the key for the props in lowercase? type JsxDOM.domProps has a key field as an optional there.

[mununki]

It seems fine in v4 sample project. More clean js output.

// as-is
function V4$Baz(props) {
  var name = props.name;
  var name$1 = name !== undefined ? name : "baz";
  var tmp = {};
  if (props.id2 !== undefined) {
    tmp.id = Caml_option.valFromOption(props.id2);
  }
  return React.createElement("div", tmp, name$1, props.children);
}

// to-be
function V4$Baz(props) {
  var name = props.name;
  var name$1 = name !== undefined ? name : "baz";
  return React.createElement("div", {
              id: props.id2
            }, name$1, props.children);
}

I'll run on the largest project.

[mununki]

I'll run on the largest project.

It works fine on my company project!

[cristianoc]

@cristianoc What about the key for the props in lowercase? type JsxDOM.domProps has a key field as an optional there.

Seems OK to have key there: we know ahead of time it's one of the possible things to send.

[mununki]

I think I don't have anything left for this PR now.

[cristianoc]

Ready to merge?

[cristianoc]

How about updating the changelog?

[mununki]

How about updating the changelog?

Sure, I’ll.

[mununki]

How about updating the changelog?

I've added to Polish 4d4bb2c

[cristianoc]

Not sure why suddenly CI gives a compile error on build

[mununki]

Let me rebase to the master

[mununki]

Build fixed 07190b4