This repository was archived by the owner on Jun 15, 2023. It is now read-only.
More robust parse recovery after ".". #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See rescript-lang/rescript-vscode#416 for examples where parser recovery goes wrong in template expressions. Basically, if the token after "." is consumed in recovery, the entire template expression is eaten up and never recovers. This PR changes error recovery to not consume the token after Dot so the parser can recover properly inside a template.
cristianoc
added a commit
to rescript-lang/rescript-vscode
that referenced
this pull request
May 12, 2022
cristianoc
added a commit
to rescript-lang/rescript-vscode
that referenced
this pull request
May 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rescript-lang/rescript-vscode#416 for examples where parser recovery goes wrong in template expressions.
Basically, if the token after "." is consumed in recovery, the entire template expression is eaten up and never recovers.
This PR changes error recovery to not consume the token after Dot so the parser can recover properly inside a template.