-
Notifications
You must be signed in to change notification settings - Fork 473
migrate Exn.Error to JsExn #8036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
2ba740c to
6be388d
Compare
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
zth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! I'm guessing this is heavily LLM influenced? Regardless, was adding something to the migration tool easy enough?
@zth If you want the whole story, I first added the tests and tried to make it work using the existing I'll rename the annotation to replace.constructor! |
|
@tsnobip great, that process makes me glad! Hopefully means extending it is pretty easy for LLMs. |
6be388d to
c0c5eb6
Compare
No description provided.