Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove postinstall script #7350

Merged
merged 3 commits into from
Mar 19, 2025
Merged

remove postinstall script #7350

merged 3 commits into from
Mar 19, 2025

Conversation

cometkim
Copy link
Member

No package manager except NPM runs postinstall by default. We shouldn't have any feature relying on it.

cknitt
cknitt approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover from earlier days, good to get rid of this! 👍

@cometkim cometkim merged commit a99dba1 into rescript-lang:master Mar 19, 2025
20 checks passed
@cometkim cometkim deleted the no-postinstall branch March 19, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cknitt cknitt cknitt approved these changes

@fhammerschmidt fhammerschmidt Awaiting requested review from fhammerschmidt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cometkim @cknitt