Remove jsx mode

[nojaf]

See comment

[zth]

Great job! Maybe @cristianoc would like to eye this one quickly as well?

[cristianoc]

Looks great. Just do double check: -bs-jsx-mode is never use-facing right? Otherwise it could be kept on the command-line and made no-op.
Perhaps rewatch?

Ah yes:

    pub fn get_jsx_mode_args(&self) -> Vec<String> {
        match self.jsx.to_owned() {
            Some(jsx) => match jsx.mode {
                Some(JsxMode::Classic) => {
                    vec!["-bs-jsx-mode".to_string(), "classic".to_string()]
                }
                Some(JsxMode::Automatic) => {
                    vec!["-bs-jsx-mode".to_string(), "automatic".to_string()]
                }

                None => vec![],
            },
            _ => vec![],
        }
    }

[nojaf]

I didn't change the Rust code here, because I assume we sync it from another place.

[nojaf]

Looks great. Just do double check: -bs-jsx-mode is never use-facing right? Otherwise it could be kept on the command-line and made no-op.

-bs-jsx-mode is only a flag in bsc. So, I'm not sure if that is public or not.
Do I need to take any actions here?

[zth]

Looks great. Just do double check: -bs-jsx-mode is never use-facing right? Otherwise it could be kept on the command-line and made no-op.

-bs-jsx-mode is only a flag in bsc. So, I'm not sure if that is public or not. Do I need to take any actions here?

Rewatch adds it when it runs bsc, so an easy way to make that cross-compatible is to just add back the -bs-jsx-mode arg (so the CLI doesn't crash when it's passed) but make it noop. So if you could do that, it'd be great and give a smoother experience.

[cristianoc]

Looks great!

[cknitt]

Great work! 👍