replace ~date with ~day for Date.make* #7324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cknitt
reviewed
Mar 7, 2025
| @@ -9,6 +9,7 @@ | |||
| } | |||
| }, | |||
| "../../..": { | |||
| "name": "rescript", | |||
There was a problem hiding this comment.
I've seen this changing back and forth, maybe depending on npm version or something. Best not include these changes in the PR?
There was a problem hiding this comment.
ok I can remove it, I think latest node versions add it, so I thought we might as well commit and stop seeing this change once for all, but it might be not as consistant as I thought.
cknitt
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
~dateis ambiguous and MDN referencesdayanyway.