Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add popover attributes #7317

Merged
merged 6 commits into from
Feb 27, 2025
Merged

Conversation

dkirchhof
Copy link
Contributor

Adds popover, popoverTarget and popoverTargetAction to JsxDOM.domProps

dkirchhof and others added 3 commits February 26, 2025 20:25
Co-authored-by: Florian Verdonck <florian.verdonck@outlook.com>
Co-authored-by: Florian Verdonck <florian.verdonck@outlook.com>
Co-authored-by: Florian Verdonck <florian.verdonck@outlook.com>
@dkirchhof
Copy link
Contributor Author

🤔 Do I have to write the Completion.res.txt stuff manually or is there a script to generate it?

@nojaf
Copy link
Collaborator

nojaf commented Feb 26, 2025

Try running make test inside tests/analysis_tests. (Or something along those lines, on my phone now)

@dkirchhof
Copy link
Contributor Author

Unfortunatelly I don't get the toolchain running. Probably my python version is too new.
I didn't want to put much effort into this small change. Feel free to close this PR or maybe someone else could fix the tests.

@nojaf
Copy link
Collaborator

nojaf commented Feb 27, 2025

I'm sorry to hear that! I completely understand how demotivating it can be to deal with CI for such a small change. Contributing here does require some setup; it can be frustrating initially, but it's smooth once everything works. I've pushed the change to the test file, so it should be ready for review now.

@dkirchhof
Copy link
Contributor Author

I'm sorry to hear that! I completely understand how demotivating it can be to deal with CI for such a small change. Contributing here does require some setup; it can be frustrating initially, but it's smooth once everything works. I've pushed the change to the test file, so it should be ready for review now.

Every now and then I played a bit with ocaml. So opam for example was already installed. But failing with make ninja etc. I gave up.

Many thanks for adding the completions.

Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@zth zth merged commit f37173f into rescript-lang:master Feb 27, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants