-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add popover attributes #7317
add popover attributes #7317
Conversation
Co-authored-by: Florian Verdonck <florian.verdonck@outlook.com>
Co-authored-by: Florian Verdonck <florian.verdonck@outlook.com>
Co-authored-by: Florian Verdonck <florian.verdonck@outlook.com>
🤔 Do I have to write the Completion.res.txt stuff manually or is there a script to generate it? |
Try running |
Unfortunatelly I don't get the toolchain running. Probably my python version is too new. |
I'm sorry to hear that! I completely understand how demotivating it can be to deal with CI for such a small change. Contributing here does require some setup; it can be frustrating initially, but it's smooth once everything works. I've pushed the change to the test file, so it should be ready for review now. |
Every now and then I played a bit with ocaml. So opam for example was already installed. But failing with Many thanks for adding the completions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff!
Adds
popover
,popoverTarget
andpopoverTargetAction
toJsxDOM.domProps