Add Dict.has & improve Dict helpers performance #7316
Conversation
| @@ -29,7 +29,7 @@ let forEach = (dict, f) => { | |||
| } | |||
|
|
|||
| let forEachWithKey = (dict, f) => { | |||
| dict->toArray->Stdlib_Array.forEach(((key, value)) => f(value, key)) | |||
| dict->keysToArray->Stdlib_Array.forEach(key => f(dict->getUnsafe(key), key)) | |||
| Object.keys(dict).forEach(key => { | ||
| let value = dict[key]; |
|
Ready for review |
| target[key] = f(value); | ||
| }); | ||
| return target; | ||
| } | ||
|
|
||
| let has = ((dict, key) => key in dict); |
There was a problem hiding this comment.
don't we want to use hasOwnProperty there?
There was a problem hiding this comment.
Yes. There are not many prototype fields on dict object, but still this is invalid with in:
console.log("__proto__" in {}) // true
There was a problem hiding this comment.
Or should we even use https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/hasOwn ?
There was a problem hiding this comment.
I suggest to keep the in usage. Since it's the fastest and has a decent browser compact. I think there's a really tiny chance for it to become a problem, especially when used on dict. Later, we can move it external and decided which one to use in compile time.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/in
https://jsbenchmark.com/#eyJjYXNlcyI6W3siaWQiOiJWdEx6SzlYNG9fejF0WXQwSG43VWIiLCJjb2RlIjoicmV0dXJuIFwiY29uc3RcIiBpbiBEQVRBIiwiZGVwZW5kZW5jaWVzIjpbXX0seyJpZCI6Ii1xTDJleHRvYlBMM2xHSUw2NVZCdiIsImNvZGUiOiJyZXR1cm4gT2JqZWN0Lmhhc093bihEQVRBLCBcImNvbnN0XCIpIiwiZGVwZW5kZW5jaWVzIjpbXX0seyJpZCI6IjRfbWhmeEpFTGVKTUdGb0J3NXVOaiIsImNvZGUiOiJyZXR1cm4gT2JqZWN0LnByb3RvdHlwZS5oYXNPd25Qcm9wZXJ0eShEQVRBLCBcImNvbnN0XCIpIiwiZGVwZW5kZW5jaWVzIjpbXX0seyJpZCI6InoyR1JEUElmamVzWkRIS2lEaXRrQiIsImNvZGUiOiJyZXR1cm4gREFUQS5oYXNPd25Qcm9wZXJ0eShcImNvbnN0XCIpIiwiZGVwZW5kZW5jaWVzIjpbXX1dLCJjb25maWciOnsibmFtZSI6IkJhc2ljIGV4YW1wbGUiLCJwYXJhbGxlbCI6dHJ1ZSwiZ2xvYmFsVGVzdENvbmZpZyI6eyJkZXBlbmRlbmNpZXMiOltdfSwiZGF0YUNvZGUiOiJyZXR1cm4ge1xuICBjb25zdDogdW5kZWZpbmVkXG59In19
No description provided.