Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocaml 5.3 #7294

Merged
merged 6 commits into from
Feb 16, 2025
Merged

Ocaml 5.3 #7294

merged 6 commits into from
Feb 16, 2025

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Feb 15, 2025

  • Some dependency upgrades required, including ocamlformat and ocaml-lsp-server
  • Some reformatting required for ocamlformat 0.27.0
  • effect is a reserved word now
  • OCaml 4.14 is the minimum version supported now
  • It is unclear when (or whether at all) @cristianoc will release a 5.3 compatible version of reanalyze. Therefore it is removed from the dependencies. However, we also build the compiler for older versions (just to check), and for 5.2.1 I then install and run reanalyze additionally.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Syntax Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite Current: bb2ed44 Previous: 5d9c682 Ratio
Parse RedBlackTree.res - time/run 1.9625067999999999 ms 1.3523686533333334 ms 1.45
Print RedBlackTree.res - time/run 3.1651597999999996 ms 1.98472278 ms 1.59
Print RedBlackTreeNoComments.res - time/run 2.8847230533333335 ms 1.8453905533333332 ms 1.56
Parse Napkinscript.res - time/run 64.56635015333333 ms 42.23872597333333 ms 1.53
Print Napkinscript.res - time/run 108.80361049333332 ms 60.21953604666667 ms 1.81
Parse HeroGraphic.res - time/run 7.774072459999999 ms 5.70670238 ms 1.36
Print HeroGraphic.res - time/run 13.317653786666666 ms 8.188623 ms 1.63

This comment was automatically generated by workflow using github-action-benchmark.

@cknitt
Copy link
Member Author

cknitt commented Feb 15, 2025

Not sure why the benchmarks seem significantly worse in CI. Not seeing that locally.

@cknitt cknitt requested review from zth and cristianoc February 15, 2025 17:08
@cknitt cknitt marked this pull request as ready for review February 15, 2025 17:08
Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cknitt cknitt merged commit 7b375c0 into master Feb 16, 2025
20 checks passed
@cknitt cknitt deleted the ocaml-5.3 branch February 16, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants