Fix issue with type environments and unified ops. #7277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Syntax Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.
| Benchmark suite | Current: f63cc17 | Previous: e1b7fb7 | Ratio |
|---|---|---|---|
Parse RedBlackTree.res - time/run |
1.3625955933333331 ms |
1.2123143266666667 ms |
1.12 |
Parse Napkinscript.res - time/run |
42.28882162 ms |
39.28006235333333 ms |
1.08 |
Parse HeroGraphic.res - time/run |
5.747935586666666 ms |
5.13472718 ms |
1.12 |
This comment was automatically generated by workflow using github-action-benchmark.
cristianoc
force-pushed
the
env-unified-ops
branch
from
67192ee to
53a5f65
Compare
Merged
cknitt
reviewed
Feb 5, 2025
cristianoc
force-pushed
the
env-unified-ops
branch
from
53a5f65 to
f63cc17
Compare
cknitt
approved these changes
Feb 5, 2025
|
Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7275