Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy attributes from original binding expression #7260

Merged
merged 4 commits into from
Jan 30, 2025

Conversation

nojaf
Copy link
Collaborator

@nojaf nojaf commented Jan 29, 2025

Fixes #7257

@cristianoc or @cknitt how can I add a test for this?
Worked for my local sample.

@cristianoc
Copy link
Collaborator

Fixes #7257

@cristianoc or @cknitt how can I add a test for this? Worked for my local sample.

You could e.g. extend tests/tests/src/alias_default_value_test.res or create a similar file

nojaf added 2 commits January 29, 2025 18:59
@nojaf nojaf marked this pull request as ready for review January 29, 2025 18:00
@nojaf nojaf requested a review from cristianoc January 29, 2025 18:00
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@cristianoc cristianoc merged commit e3f28e2 into rescript-lang:master Jan 30, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot combine @react.component and @directive
2 participants