Use identical variant names for arg_label and arg_label_loc.
#7254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In several places, additional type annotations need to be added to disambiguate which definition is used: with or without location. In exchange, the naming is uniform.
cristianoc
commented
Jan 25, 2025
| @@ -952,7 +952,9 @@ and getCompletionsForContextPath ~debug ~full ~opens ~rawOpens ~pos ~env ~exact | |||
| (* compute the application of the first label, then the next ones *) | |||
| let args = processApply args [label] in | |||
| processApply args nextLabels | |||
| | (Asttypes.Nolabel, _) :: nextArgs, [Asttypes.Nolabel] -> nextArgs | |||
| | ( ((Nolabel : Asttypes.arg_label), _) :: nextArgs, | |||
There was a problem hiding this comment.
Example of extra type annotations.
cristianoc
commented
Jan 25, 2025
| @@ -169,8 +169,8 @@ let printSignature ~extractor ~signature = | |||
| labelDecl.ld_type | |||
| in | |||
| let lblName = labelDecl.ld_id |> Ident.name in | |||
| let lbl = | |||
| if labelDecl.ld_optional then Asttypes.Optional lblName | |||
| let lbl : Asttypes.arg_label = | |||
There was a problem hiding this comment.
Another example of annotation required.
|
Closing as this is superseded by the better solution in #7247 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In several places, additional type annotations need to be added to disambiguate which definition is used: with or without location. In exchange, the naming is uniform.