Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docstring tests #7219

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Add docstring tests #7219

merged 1 commit into from
Jan 5, 2025

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Dec 27, 2024 •
edited
Loading

  • Add Pervasives.assertEqual
  • Add assertions to doc examples
  • Add docstring tests and run them in CI:
    • Extract docstrings into Mocha tests (in a single source file for performance)
    • Compile and run Mocha tests

Supersedes #7184

@cknitt cknitt changed the title Attempt to fix doc tests for macOS Add docstring tests Dec 30, 2024
@cknitt cknitt force-pushed the doc-tests-fix branch 2 times, most recently from bf0224c to edce512 Compare January 4, 2025 08:30
@cknitt cknitt marked this pull request as ready for review January 4, 2025 08:30
@cknitt cknitt requested a review from zth January 4, 2025 08:34
@cknitt cknitt requested a review from fhammerschmidt January 4, 2025 13:16
@cknitt @aspeddro
Add docstring tests
b5fb5be 
Co-authored-by: Pedro Castro <aspeddro@gmail.com>
@cknitt cknitt merged commit 3500728 into master Jan 5, 2025
20 checks passed
@cknitt cknitt deleted the doc-tests-fix branch January 5, 2025 07:43
@cknitt cknitt mentioned this pull request Jan 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhammerschmidt fhammerschmidt

@zth zth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cknitt @fhammerschmidt