AST cleanup: use inline record for Pexp_fun. #7213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
force-pushed
the
pexp_fun_inline_record
branch
from
b5a7309 to
f6dbcc8
Compare
cknitt
reviewed
Dec 23, 2024
CHANGELOG.md
Outdated
| @@ -40,6 +40,7 @@ | |||
| - AST cleanup: store arity in function type. https://github.com/rescript-lang/rescript/pull/7195 | |||
| - AST cleanup: remove explicit uses of `function$` in preparation for removing the type entirely. https://github.com/rescript-lang/rescript/pull/7206 | |||
| - AST cleanup: remove `function$` entirely. https://github.com/rescript-lang/rescript/pull/7208 | |||
| - AST cleanup: use inline record for Pexp_fun. https://github.com/rescript-lang/rescript/pull/7213 | |||
compiler/ml/pprintast.ml
Outdated
| @@ -543,7 +543,7 @@ and expression ctxt f x = | |||
| | Pexp_let _ | Pexp_letmodule _ | Pexp_open _ | Pexp_letexception _ | |||
| when ctxt.semi -> | |||
| paren true (expression reset_ctxt) f x | |||
| | Pexp_fun (l, e0, p, e, arity) -> | |||
| | Pexp_fun {arg_label=l; default= e0; lhs= p; rhs= e; arity} -> | |||
There was a problem hiding this comment.
Is this not formatted with ocamlformat? As there are different spaces around =.
There was a problem hiding this comment.
Good question.
Perhaps it gets stuck somewhere in the file.
There was a problem hiding this comment.
It was not formatted as there are some cppo ifdef's.
There are all these cppo configs:
(env
(dev
(env-vars
(CPPO_FLAGS -U=RELEASE)))
(release
(env-vars
(CPPO_FLAGS -D=RELEASE))
(ocamlopt_flags
(:standard -O3 -unbox-closures)))
(static
(env-vars
(CPPO_FLAGS -D=RELEASE))
(ocamlopt_flags
(:standard -O3 -unbox-closures)))
(browser
(env-vars
(CPPO_FLAGS -D=BROWSER))
(ocamlopt_flags
(:standard -O3 -unbox-closures))))
do we actually need them? All of them?
cristianoc
force-pushed
the
pexp_fun_inline_record
branch
from
f6dbcc8 to
9829671
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.