-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all standard CSS properties to JsxDOMStyle
#7205
Add all standard CSS properties to JsxDOMStyle
#7205
Conversation
Another option is to define props by variant type. scrollbarWidth?: scrollbarWidth, @unboxed
type scrollbarWidth =
| @as("auto") Auto
| @as("thin") Thin
| @as("none") None
| ...globals I think just keep it as string and use extra packages (like |
24fbfe4
to
37568d9
Compare
Nice work so far! Yes strings are fine since you should use a CSS library anyway in most cases. However I don't really get all the Tagging @nojaf since he did some work on the new webapi which might need some alignment here. |
Some of those properties are in CSS 2.1 but removed in CSS 3 (like Those in draft should be kept. But I'm not sure how to do with the others? |
Well, let's stay as simple as possible: If MDN says it is deprecated, it should probably be deprecated, otherwise not. |
I think just keep them. They are not on MDN. |
37568d9
to
c457cde
Compare
Looks good. Now please add an entry to the changelog and we are good to go. |
dbc1522
to
4829c73
Compare
4829c73
to
332a988
Compare
Thanks for merging. Glad to contribute to Rescript. |
JsxDOMStyle
lacks some properties that already in CSS standards (e.g.aspectRatio
,scrollbarWidth
).The top half are from https://github.com/mdn/data/blob/main/css/properties.json and filtered by:
The bottom half are those already in
JsxDOMStyle
but not in current CSS standards.Here are the script to generate new record fields (https://github.com/stephanoskomnenos/rescript-cssprops/blob/main/scripts/generate.ts).